lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Oct 2020 17:35:32 -0700 (PDT) From: Mat Martineau <mathew.j.martineau@...ux.intel.com> To: Matthieu Baerts <matthieu.baerts@...sares.net> cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Shuah Khan <shuah@...nel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>, netdev@...r.kernel.org, mptcp@...ts.01.org, linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net] selftests: mptcp: depends on built-in IPv6 On Wed, 21 Oct 2020, Matthieu Baerts wrote: > Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a > consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no > longer ensure CONFIG_IPV6=y. If it is not enabled, CONFIG_MPTCP_IPV6 > will stay disabled and selftests will fail. > > We also need CONFIG_IPV6 to be built-in. For more details, please see > commit 0ed37ac586c0 ("mptcp: depends on IPV6 but not as a module"). > > Note that 'make kselftest-merge' will take all 'config' files found in > 'tools/testsing/selftests'. Because some of them already set > CONFIG_IPV6=y, MPTCP selftests were still passing. But they will fail if > MPTCP selftests are launched manually after having executed this command > to prepare the kernel config: > > ./scripts/kconfig/merge_config.sh -m .config \ > ./tools/testing/selftests/net/mptcp/config > > Fixes: 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it") > Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net> > --- > tools/testing/selftests/net/mptcp/config | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com> -- Mat Martineau Intel
Powered by blists - more mailing lists