netdev - Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Oct 2020 18:27:18 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Łukasz Stelmach <l.stelmach@...sung.com>,
        devicetree@...r.kernel.org, Kukjin Kim <kgene@...nel.org>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Bartłomiej Żolnierkiewicz 
        <b.zolnierkie@...sung.com>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, jim.cromie@...il.com,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI
 Ethernet Adapter

On Fri, 23 Oct 2020 at 18:05, Rob Herring <robh@...nel.org> wrote:
>
> On Wed, 21 Oct 2020 23:49:07 +0200, Łukasz Stelmach wrote:
> > Add bindings for AX88796C SPI Ethernet Adapter.
> >
> > Signed-off-by: Łukasz Stelmach <l.stelmach@...sung.com>
> > ---
> >  .../bindings/net/asix,ax88796c.yaml           | 69 +++++++++++++++++++
> >  1 file changed, 69 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml
> >
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> ./Documentation/devicetree/bindings/net/asix,ax88796c.yaml: $id: relative path/filename doesn't match actual path or filename
>         expected: http://devicetree.org/schemas/net/asix,ax88796c.yaml#
> Documentation/devicetree/bindings/net/asix,ax88796c.example.dts:20:18: fatal error: dt-bindings/interrupt-controller/gpio.h: No such file or directory

Łukasz,

So you really did not compile/test these patches... It's the second
build failure in the patchset. All sent patches should at least be
compiled on the latest kernel, if you cannot test them. However this
patchset should be testable - Artik5 should boot on mainline kernel

Best regards,
Krzysztof