netdev - Re: [net] tcp: Prevent low rmem stalls with SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 23 Oct 2020 11:49:04 -0700
From:   Arjun Roy <arjunroy@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Arjun Roy <arjunroy.kdev@...il.com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>
Subject: Re: [net] tcp: Prevent low rmem stalls with SO_RCVLOWAT.

Acknowledged, I have rebased onto net master just now and I think that
should fix the sha1 information. v2 patch has been mailed. Sorry for
the error first time round :)

-Arjun

On Fri, Oct 23, 2020 at 11:31 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 23 Oct 2020 10:48:57 -0700 Arjun Roy wrote:
> > From: Arjun Roy <arjunroy@...gle.com>
> >
> > With SO_RCVLOWAT, under memory pressure,
> > it is possible to enter a state where:
> >
> > 1. We have not received enough bytes to satisfy SO_RCVLOWAT.
> > 2. We have not entered buffer pressure (see tcp_rmem_pressure()).
> > 3. But, we do not have enough buffer space to accept more packets.
>
> Doesn't apply cleanly to net:
>
> Applying: tcp: Prevent low rmem stalls with SO_RCVLOWAT.
> error: sha1 information is lacking or useless (net/ipv4/tcp.c).
> error: could not build fake ancestor
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> Patch failed at 0001 tcp: Prevent low rmem stalls with SO_RCVLOWAT.
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".