netdev - KMSAN: uninit-value in ax88179_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <000000000000b731f405b2521197@google.com>
Date:   Fri, 23 Oct 2020 01:07:17 -0700
From:   syzbot <syzbot+4993e4a0e237f1b53747@...kaller.appspotmail.com>
To:     andrew@...n.ch, besslein.andreas@...il.com,
        bjorn.andersson@...aro.org, colin.king@...onical.com,
        davem@...emloft.net, glider@...gle.com, jk@...abs.org,
        kuba@...nel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        pfink@...ist-es.de, syzkaller-bugs@...glegroups.com
Subject: KMSAN: uninit-value in ax88179_get_mac_addr

Hello,

syzbot found the following issue on:

HEAD commit:    ce8056d1 wip: changed copy_from_user where instrumented
git tree:       https://github.com/google/kmsan.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=11212a66900000
kernel config:  https://syzkaller.appspot.com/x/.config?x=3afe005fb99591f
dashboard link: https://syzkaller.appspot.com/bug?extid=4993e4a0e237f1b53747
compiler:       clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81)
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=12ceb4b6900000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1645f266900000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+4993e4a0e237f1b53747@...kaller.appspotmail.com

ax88179_178a 1-1:101.123 (unnamed net_device) (uninitialized): Failed to write reg index 0x0002: -71
ax88179_178a 1-1:101.123 (unnamed net_device) (uninitialized): Failed to write reg index 0x0002: -71
ax88179_178a 1-1:101.123 (unnamed net_device) (uninitialized): Failed to write reg index 0x0001: -71
ax88179_178a 1-1:101.123 (unnamed net_device) (uninitialized): Failed to read reg index 0x0006: -71
=====================================================
BUG: KMSAN: uninit-value in is_valid_ether_addr include/linux/etherdevice.h:195 [inline]
BUG: KMSAN: uninit-value in ax88179_get_mac_addr+0x481/0x850 drivers/net/usb/ax88179_178a.c:1310
CPU: 0 PID: 3337 Comm: kworker/0:2 Not tainted 5.8.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x21c/0x280 lib/dump_stack.c:118
 kmsan_report+0xf7/0x1e0 mm/kmsan/kmsan_report.c:121
 __msan_warning+0x58/0xa0 mm/kmsan/kmsan_instr.c:215
 is_valid_ether_addr include/linux/etherdevice.h:195 [inline]
 ax88179_get_mac_addr+0x481/0x850 drivers/net/usb/ax88179_178a.c:1310
 ax88179_bind+0x3ec/0x19c0 drivers/net/usb/ax88179_178a.c:1348
 usbnet_probe+0x1152/0x3f90 drivers/net/usb/usbnet.c:1737
 usb_probe_interface+0xece/0x1550 drivers/usb/core/driver.c:374
 really_probe+0xf20/0x20b0 drivers/base/dd.c:529
 driver_probe_device+0x293/0x390 drivers/base/dd.c:701
 __device_attach_driver+0x63f/0x830 drivers/base/dd.c:807
 bus_for_each_drv+0x2ca/0x3f0 drivers/base/bus.c:431
 __device_attach+0x4e2/0x7f0 drivers/base/dd.c:873
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:920
 bus_probe_device+0x177/0x3d0 drivers/base/bus.c:491
 device_add+0x3b0e/0x40d0 drivers/base/core.c:2680
 usb_set_configuration+0x380f/0x3f10 drivers/usb/core/message.c:2032
 usb_generic_driver_probe+0x138/0x300 drivers/usb/core/generic.c:241
 usb_probe_device+0x311/0x490 drivers/usb/core/driver.c:272
 really_probe+0xf20/0x20b0 drivers/base/dd.c:529
 driver_probe_device+0x293/0x390 drivers/base/dd.c:701
 __device_attach_driver+0x63f/0x830 drivers/base/dd.c:807
 bus_for_each_drv+0x2ca/0x3f0 drivers/base/bus.c:431
 __device_attach+0x4e2/0x7f0 drivers/base/dd.c:873
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:920
 bus_probe_device+0x177/0x3d0 drivers/base/bus.c:491
 device_add+0x3b0e/0x40d0 drivers/base/core.c:2680
 usb_new_device+0x1bd4/0x2a30 drivers/usb/core/hub.c:2554
 hub_port_connect drivers/usb/core/hub.c:5208 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5348 [inline]
 port_event drivers/usb/core/hub.c:5494 [inline]
 hub_event+0x5e7b/0x8a70 drivers/usb/core/hub.c:5576
 process_one_work+0x1688/0x2140 kernel/workqueue.c:2269
 worker_thread+0x10bc/0x2730 kernel/workqueue.c:2415
 kthread+0x551/0x590 kernel/kthread.c:292
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293

Local variable ----mac@...8179_get_mac_addr created at:
 ax88179_get_mac_addr+0x4d/0x850 drivers/net/usb/ax88179_178a.c:1297
 ax88179_get_mac_addr+0x4d/0x850 drivers/net/usb/ax88179_178a.c:1297
=====================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@...glegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches