lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 24 Oct 2020 16:37:56 +0200 From: Andrew Lunn <andrew@...n.ch> To: Xu Yilun <yilun.xu@...el.com> Cc: jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com, davem@...emloft.net, kuba@...nel.org, mdf@...nel.org, lee.jones@...aro.org, linux-kernel@...r.kernel.org, linux-fpga@...r.kernel.org, netdev@...r.kernel.org, trix@...hat.com, lgoncalv@...hat.com, hao.wu@...el.com, Russ Weight <russell.h.weight@...el.com> Subject: Re: [RFC PATCH 5/6] ethernet: dfl-eth-group: add DFL eth group private feature driver > +++ b/Documentation/ABI/testing/sysfs-class-net-dfl-eth-group > @@ -0,0 +1,19 @@ > +What: /sys/class/net/<iface>/tx_pause_frame_quanta > +Date: Oct 2020 > +KernelVersion: 5.11 > +Contact: Xu Yilun <yilun.xu@...el.com> > +Description: > + Read-Write. Value representing the tx pause quanta of Pause > + flow control frames to be sent to remote partner. Read the file > + for the actual tx pause quanta value. Write the file to set > + value of the tx pause quanta. > + Is this really configuring the quanta? My very limited understanding is that the quanta is defined as 512 bit times. For this to work, you are going to have to modify the quanta on both ends of the link, otherwise increasing the quanta is actually going to shorten the pause time. > +What: /sys/class/net/<iface>/tx_pause_frame_holdoff > +Date: Oct 2020 > +KernelVersion: 5.11 > +Contact: Xu Yilun <yilun.xu@...el.com> > +Description: > + Read-Write. Value representing the separation between 2 > + consecutive XOFF flow control frames. Read the file for the > + actual separation value. Write the file to set value of the > + separation. This is the wrong API for this. Please extend the ethtool -A|--pause API. Now that it is netlink, adding extra attributes should be simple. Andrew
Powered by blists - more mailing lists