netdev - Re: [PATCH iproute2-next v4 1/2] tc: skip actions that don't have options attribute when printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <598d7a76-e8c4-f6a5-c270-31f8072492ab@mojatatu.com>
Date:   Sat, 24 Oct 2020 13:41:19 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Vlad Buslov <vladbu@...dia.com>, dsahern@...il.com,
        stephen@...workplumber.org
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        xiyou.wangcong@...il.com, jiri@...nulli.us, ivecera@...hat.com,
        vlad@...lov.dev, Vlad Buslov <vladbu@...lanox.com>
Subject: Re: [PATCH iproute2-next v4 1/2] tc: skip actions that don't have
 options attribute when printing

On 2020-10-23 10:55 a.m., Vlad Buslov wrote:
> From: Vlad Buslov <vladbu@...lanox.com>
> 
> Modify implementations that return error from action_until->print_aopt()
> callback to silently skip actions that don't have their corresponding
> TCA_ACT_OPTIONS attribute set (some actions already behave like this).
> Print action kind before returning from action_until->print_aopt()
> callbacks. This is necessary to support terse dump mode in following patch
> in the series.
> 
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
> Suggested-by: Jamal Hadi Salim <jhs@...atatu.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal