lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Oct 2020 18:45:43 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Michael Ellerman <mpe@...erman.id.au> Cc: linuxppc-dev@...abs.org, netdev@...r.kernel.org, davem@...emloft.net, linux-kernel@...r.kernel.org, leoyang.li@....com Subject: Re: [PATCH] net: ucc_geth: Drop extraneous parentheses in comparison On Fri, 23 Oct 2020 14:32:36 +1100 Michael Ellerman wrote: > Clang warns about the extra parentheses in this comparison: > > drivers/net/ethernet/freescale/ucc_geth.c:1361:28: > warning: equality comparison with extraneous parentheses > if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII)) > ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > It seems clear the intent here is to do a comparison not an > assignment, so drop the extra parentheses to avoid any confusion. > > Signed-off-by: Michael Ellerman <mpe@...erman.id.au> Applied, thanks!
Powered by blists - more mailing lists