lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Oct 2020 08:33:56 -0700 From: Jesse Brandeburg <jesse.brandeburg@...el.com> To: Christian Langrock <christian.langrock@...unet.com> Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>, <anthony.l.nguyen@...el.com> Subject: Re: Subject: [PATCH net] drivers: net: ixgbe: Fix *_ipsec_offload_ok():, Use ip_hdr family Christian Langrock wrote: Please fix your subject, remove the word 'Subject: ' > Xfrm_dev_offload_ok() is called with the unencrypted SKB. So in case of > interfamily ipsec traffic (IPv4-in-IPv6 and IPv6 in IPv4) the check > assumes the wrong family of the skb (IP family of the state). > With this patch the ip header of the SKB is used to determine the > family. > missing "Fixes: " line? It's useful here because I think this looks like a good candidate for stable bug fix. > Signed-off-by: Christian Langrock <christian.langrock@...unet.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +- > drivers/net/ethernet/intel/ixgbevf/ipsec.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) The patch looks ok otherwise, thanks!
Powered by blists - more mailing lists