netdev - Re: [PATCH] vdpa: handle irq bypass register failure case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf3d5114-c55f-80e6-41b0-b7f5ae8ad9e9@redhat.com>
Date:   Mon, 26 Oct 2020 10:45:25 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Zhu Lingshan <lingshan.zhu@...el.com>, mst@...hat.com
Cc:     virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH] vdpa: handle irq bypass register failure case


On 2020/10/23 下午6:40, Zhu Lingshan wrote:
> LKP considered variable 'ret' in vhost_vdpa_setup_vq_irq() as
> a unused variable, so suggest we remove it. Actually it stores
> return value of irq_bypass_register_producer(), but we did not
> check it, we should handle the failure case.
>
> This commit will print a message if irq bypass register producer
> fail, in this case, vqs still remain functional.
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@...el.com>
> Reported-by: kernel test robot <lkp@...el.com>
> ---
>   drivers/vhost/vdpa.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index 62a9bb0efc55..d6b2c3bd1b01 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -107,6 +107,9 @@ static void vhost_vdpa_setup_vq_irq(struct vhost_vdpa *v, u16 qid)
>   	vq->call_ctx.producer.token = vq->call_ctx.ctx;
>   	vq->call_ctx.producer.irq = irq;
>   	ret = irq_bypass_register_producer(&vq->call_ctx.producer);
> +	if (unlikely(ret))
> +		dev_info(&v->dev, "vq %u, irq bypass producer (token %p) registration fails, ret =  %d\n",
> +			 qid, vq->call_ctx.producer.token, ret);
>   	spin_unlock(&vq->call_ctx.ctx_lock);
>   }
>   


Acked-by: Jason Wang <jasowang@...hat.com>