netdev - Re: [PATCH] RDMA: Add rdma_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Oct 2020 09:00:41 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Chao Leng <lengchao@...wei.com>
CC:     Danil Kipnis <danil.kipnis@...ud.ionos.com>,
        Doug Ledford <dledford@...hat.com>,
        Christoph Hellwig <hch@....de>,
        Jack Wang <jinpu.wang@...ud.ionos.com>,
        Keith Busch <kbusch@...nel.org>,
        <linux-nvme@...ts.infradead.org>, <linux-rdma@...r.kernel.org>,
        Max Gurtovoy <mgurtovoy@...dia.com>, <netdev@...r.kernel.org>,
        <rds-devel@....oracle.com>, Sagi Grimberg <sagi@...mberg.me>,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>,
        Guoqing Jiang <guoqing.jiang@...ud.ionos.com>,
        Leon Romanovsky <leonro@...dia.com>
Subject: Re: [PATCH] RDMA: Add rdma_connect_locked()

On Tue, Oct 27, 2020 at 10:01:00AM +0800, Chao Leng wrote:
> > diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> > index aad829a2b50d0f..f488dc5f4c2c61 100644
> > +++ b/drivers/nvme/host/rdma.c
> > @@ -1730,11 +1730,10 @@ static void nvme_rdma_process_nvme_rsp(struct nvme_rdma_queue *queue,
> >   	req->result = cqe->result;
> >   	if (wc->wc_flags & IB_WC_WITH_INVALIDATE) {
> > -		if (unlikely(!req->mr ||
> > -			     wc->ex.invalidate_rkey != req->mr->rkey)) {
> > +		if (unlikely(wc->ex.invalidate_rkey != req->mr->rkey)) {
> >   			dev_err(queue->ctrl->ctrl.device,
> >   				"Bogus remote invalidation for rkey %#x\n",
> > -				req->mr ? req->mr->rkey : 0);
> > +				req->mr->rkey);
> Maybe the code version is incorrect, cause falsely code rollback.

Oh wow, thanks for noticing that, I made a git fumble when doing this
:(

Jason