netdev - Re: [PATCH] brcmfmac: Fix memory leak for unpaired brcmf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f7b3975-69cb-ef04-ec52-269f375c65c1@broadcom.com>
Date:   Tue, 27 Oct 2020 14:19:41 +0100
From:   Arend Van Spriel <arend.vanspriel@...adcom.com>
To:     Seung-Woo Kim <sw0312.kim@...sung.com>, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, chi-hsien.lin@...ress.com,
        wright.feng@...ress.com, kvalo@...eaurora.org, davem@...emloft.net,
        kuba@...nel.org, linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com, brcm80211-dev-list@...ress.com
Cc:     smoch@....de, sandals@...stytoothpaste.net, rafal@...ecki.pl,
        digetx@...il.com, double.lo@...ress.com, amsr@...ress.com,
        stanley.hsu@...ress.com, saravanan.shanmugham@...ress.com,
        jean-philippe@...aro.org, frank.kao@...ress.com,
        netdev@...r.kernel.org, jh80.chung@...sung.com
Subject: Re: [PATCH] brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free}

On 10/27/2020 11:47 AM, Seung-Woo Kim wrote:
> There are missig brcmf_free() for brcmf_alloc(). Fix memory leak
> by adding missed brcmf_free().

Probably should add Fixes: tag for commit a1f5aac1765af. See this link 
[1] about the proper format.

Reviewed-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Reported-by: Jaehoon Chung <jh80.chung@...sung.com>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@...sung.com>
> ---
>   .../wireless/broadcom/brcm80211/brcmfmac/pcie.c    |    6 ++++--
>   .../wireless/broadcom/brcm80211/brcmfmac/sdio.c    |    1 +
>   2 files changed, 5 insertions(+), 2 deletions(-)

[1] 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#fixes_line_is_incorrect

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4176 bytes)