lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Oct 2020 20:27:42 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Yunsheng Lin <linyunsheng@...wei.com> Cc: Zenghui Yu <yuzenghui@...wei.com>, <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>, <davem@...emloft.net>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <wanghaibin.wang@...wei.com>, <tanhuazhong@...wei.com> Subject: Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region On Tue, 27 Oct 2020 09:42:01 +0800 Yunsheng Lin wrote: > On 2020/10/27 9:25, Jakub Kicinski wrote: > > On Tue, 27 Oct 2020 09:24:10 +0800 Yunsheng Lin wrote: > >>> Fixes: 862d969a3a4d ("net: hns3: do VF's pci re-initialization while PF doing FLR") > >> > >> The correct Fixes tag should be: > >> > >> Fixes: e3338205f0c7 ("net: hns3: uninitialize pci in the hclgevf_uninit") > > > > Why is that? > > > > Isn't the issue the order of cmd vs pci calls? e3338205f0c7 only takes > > the pci call from under an if, the order was wrong before. > > You are right, the e3338205f0c7 only add the missing hclgevf_pci_uninit() > when HCLGEVF_STATE_IRQ_INITED is not set. > > So I think the tag you provided is correct, thanks. Great, added the tag and applied, thanks!
Powered by blists - more mailing lists