netdev - Re: [PATCH net-next] net: netlabel: Fix kerneldoc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhSTQrhBfMnfb0=UG=J4aa-ODu3Gqfrj9aiDr+KesuY4=g@mail.gmail.com>
Date:   Tue, 27 Oct 2020 21:01:48 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: netlabel: Fix kerneldoc warnings

On Tue, Oct 27, 2020 at 8:54 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> net/netlabel/netlabel_calipso.c:376: warning: Function parameter or member 'ops' not described in 'netlbl_calipso_ops_register'
>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
>  net/netlabel/netlabel_calipso.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/netlabel/netlabel_calipso.c b/net/netlabel/netlabel_calipso.c
> index 4e62f2ad3575..a4efa99fb1f8 100644
> --- a/net/netlabel/netlabel_calipso.c
> +++ b/net/netlabel/netlabel_calipso.c
> @@ -366,6 +366,7 @@ static const struct netlbl_calipso_ops *calipso_ops;
>
>  /**
>   * netlbl_calipso_ops_register - Register the CALIPSO operations
> + * @ops: Ops to register

If we are being nitpicky, it might be better to drop the
capitalization for the sake of consistency, e.g. "@ops: ops to
register".

Acked-by: Paul Moore <paul@...l-moore.com>

>   *
>   * Description:
>   * Register the CALIPSO packet engine operations.

-- 
paul moore
www.paul-moore.com