netdev - Re: [PATCH] mdio: use inline functions for to_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Oct 2020 16:34:09 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Russell King <linux@...linux.org.uk>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Networking <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mdio: use inline functions for to_mdio_device() etc

On Wed, Oct 28, 2020 at 2:16 AM Jakub Kicinski <kuba@...nel.org> wrote:
> On Mon, 26 Oct 2020 17:51:09 +0100 Arnd Bergmann wrote:
 >
> > Fixes: a9049e0c513c ("mdio: Add support for mdio drivers.")
>
> I feel like this is slightly onerous, please drop the tag.
>
> Harmless W=2 warnings hardly call for getting this into the cogs of
> the stable machinery.
>
...
> >       unsigned int reset_deassert_delay;
> >  };
> > -#define to_mdio_device(d) container_of(d, struct mdio_device, dev)
>
> empty line

I fixed all of those now, plan to resend next week. Thanks for
taking a look!

      Arnd