lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Oct 2020 16:19:51 +0800 From: Zou Wei <zou_wei@...wei.com> To: <davem@...emloft.net>, <kuba@...nel.org> CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Zou Wei <zou_wei@...wei.com> Subject: [PATCH -next] net: wan: sdla: Use bitwise instead of arithmetic Fix the following coccinelle warnings: ./drivers/net/wan/sdla.c:841:38-39: WARNING: sum of probable bitmasks, consider | Reported-by: Hulk Robot <hulkci@...wei.com> Signed-off-by: Zou Wei <zou_wei@...wei.com> --- drivers/net/wan/sdla.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wan/sdla.c b/drivers/net/wan/sdla.c index bc2c1c7..cf43f4c 100644 --- a/drivers/net/wan/sdla.c +++ b/drivers/net/wan/sdla.c @@ -838,7 +838,8 @@ static void sdla_receive(struct net_device *dev) case SDLA_S502A: case SDLA_S502E: if (success) - __sdla_read(dev, SDLA_502_RCV_BUF + SDLA_502_DATA_OFS, skb_put(skb,len), len); + __sdla_read(dev, SDLA_502_RCV_BUF | SDLA_502_DATA_OFS, + skb_put(skb, len), len); SDLA_WINDOW(dev, SDLA_502_RCV_BUF); cmd->opp_flag = 0; -- 2.6.2
Powered by blists - more mailing lists