netdev - Re: [PATCH v6 2/4] net: phy: Add 5GBASER interface mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201029071116.42b4bd94@nic.cz>
Date:   Thu, 29 Oct 2020 07:11:16 +0100
From:   Marek Behun <marek.behun@....cz>
To:     Pavana Sharma <pavana.sharma@...i.com>
Cc:     andrew@...n.ch, davem@...emloft.net, f.fainelli@...il.com,
        gregkh@...uxfoundation.org, kuba@...nel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        vivien.didelot@...il.com, ashkan.boldaji@...i.com
Subject: Re: [PATCH v6 2/4] net: phy: Add 5GBASER interface mode

On Thu, 29 Oct 2020 15:42:00 +1000
Pavana Sharma <pavana.sharma@...i.com> wrote:

> Add new mode supported by MV88E6393 family.
> 

This commit message isn't ideal. It infers that the Amethyst is first
such device to implement this mode, which is not true. The 5gbase-r mode
is supported by various other hardware, for example Marvell's 88X3310
PHY. Just say:
  Add 5gbase-r PHY interface mode.

>  	PHY_INTERFACE_MODE_2500BASEX,
>  	PHY_INTERFACE_MODE_RXAUI,
>  	PHY_INTERFACE_MODE_XAUI,
> +	PHY_INTERFACE_MODE_5GBASER,
>  	/* 10GBASE-R, XFI, SFI - single lane 10G Serdes */
>  	PHY_INTERFACE_MODE_10GBASER,
>  	PHY_INTERFACE_MODE_USXGMII,

The position is IMO out of order. RXAUI and XAUI are both 10G modes, so
5gbase-r should be between 2500base-x and rxaui.

> @@ -187,6 +188,8 @@ static inline const char *phy_modes(phy_interface_t interface)
>  		return "rxaui";
>  	case PHY_INTERFACE_MODE_XAUI:
>  		return "xaui";
> +	case PHY_INTERFACE_MODE_5GBASER:
> +		return "5gbase-r";
>  	case PHY_INTERFACE_MODE_10GBASER:
>  		return "10gbase-r";
>  	case PHY_INTERFACE_MODE_USXGMII:

Here as well.