netdev - Re: [PATCH net] r8169: fix operation under forced interrupt threading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87v9etdxsk.fsf@nanos.tec.linutronix.de>
Date:   Thu, 29 Oct 2020 13:25:15 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Serge Belyshev <belyshev@...ni.sinp.msu.ru>,
        David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net] r8169: fix operation under forced interrupt threading

On Thu, Oct 29 2020 at 11:19, Heiner Kallweit wrote:
> On 29.10.2020 10:42, Thomas Gleixner wrote:
> Correct, just that the legacy PCI interrupt scenario doesn't affect old
> systems/devices only. Users may run the system with nomsi for
> whatever reason and we need to be prepared.
>
> We could add handling for (pcidev->msi_enabled || pcidev->msix_enabled),
> but this would look somewhat hacky to me.

Well, there are quite some drivers which differentiate between MSI and
legacy interrupts, most of them because MSI allows them to split
handlers. So it's not completely insane.

Thanks,

        tglx