netdev - Re: [PATCH net-next 4/5] net: phy: marvell10g: change MACTYPE if underlying MAC does not support it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201029132157.GT1551@shell.armlinux.org.uk>
Date:   Thu, 29 Oct 2020 13:21:57 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next 4/5] net: phy: marvell10g: change MACTYPE if
 underlying MAC does not support it

On Wed, Oct 28, 2020 at 11:14:26PM +0100, Marek Behún wrote:
> RollBall SFPs contain a Marvell 88X3310 PHY, but by default the MACTYPE
> is set to 10GBASE-R with Rate Matching.
> 
> Some devices (for example those based on Armada 38x) only support up to
> 2500base-x SerDes modes.
> 
> Change the PHY's MACTYPE to 4 (which means changing between 10gbase-r,
> 5gbase-r, 2500base-x ans SGMII depending on copper speed) if this is the
> case (which is infered from phydev->interface).
> 
> Signed-off-by: Marek Behún <kabel@...nel.org>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Russell King <rmk+kernel@...linux.org.uk>

This'll do as a stop-gap until we have a better way to determine which
MACTYPE mode we should be using.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!