lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Oct 2020 17:12:51 -0700 From: Brian Norris <briannorris@...omium.org> To: Tsuchiya Yuto <kitakar@...il.com> Cc: Amitkumar Karwar <amitkarwar@...il.com>, Ganapathi Bhat <ganapathi.bhat@....com>, Xinming Hu <huxinming820@...il.com>, Kalle Valo <kvalo@...eaurora.org>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, linux-wireless <linux-wireless@...r.kernel.org>, "<netdev@...r.kernel.org>" <netdev@...r.kernel.org>, Linux Kernel <linux-kernel@...r.kernel.org>, Maximilian Luz <luzmaximilian@...il.com>, Andy Shevchenko <andriy.shevchenko@...el.com>, verdre@...d.nl Subject: Re: [PATCH] mwifiex: pcie: add enable_device_dump module parameter On Wed, Oct 28, 2020 at 3:58 PM Tsuchiya Yuto <kitakar@...il.com> wrote: > > The devicve_dump may take a little bit long time and users may want to > disable the dump for daily usage. > > This commit adds a new module parameter enable_device_dump and disables > the device_dump by default. As with one of your other patches, please don't change the defaults and hide them under a module parameter. If you're adding a module parameter, leave the default behavior alone. This also seems like something that might be nicer as a user-space knob in generic form (similar to "/sys/class/devcoredump/disabled", except on a per-device basis, and fed back to the driver so it doesn't waste time generating such dumps), but I suppose I can see why a module parameter (so you can just stick your configuration in /etc/modprobe.d/) might be easier to deal with in some cases. Brian
Powered by blists - more mailing lists