netdev - Re: [PATCH net] r8169: fix issue with forced threading in combination with shared interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201029114826.76567cc5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 29 Oct 2020 11:48:26 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Serge Belyshev <belyshev@...ni.sinp.msu.ru>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] r8169: fix issue with forced threading in
 combination with shared interrupts

On Thu, 29 Oct 2020 14:37:35 +0300 Serge Belyshev wrote:
> > As reported by Serge flag IRQF_NO_THREAD causes an error if the
> > interrupt is actually shared and the other driver(s) don't have this
> > flag set. This situation can occur if a PCI(e) legacy interrupt is
> > used in combination with forced threading.
> > There's no good way to deal with this properly, therefore we have to
> > remove flag IRQF_NO_THREAD. For fixing the original forced threading
> > issue switch to napi_schedule().
> >
> > Fixes: 424a646e072a ("r8169: fix operation under forced interrupt threading")
> > Link: https://www.spinics.net/lists/netdev/msg694960.html
> > Reported-by: Serge Belyshev <belyshev@...ni.sinp.msu.ru>
> > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 
> Tested-by: Serge Belyshev <belyshev@...ni.sinp.msu.ru>

Applied, thanks!