netdev - Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201029175305-mutt-send-email-mst@kernel.org>
Date:   Thu, 29 Oct 2020 17:53:12 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     si-wei liu <si-wei.liu@...cle.com>
Cc:     Jason Wang <jasowang@...hat.com>, lingshan.zhu@...el.com,
        joao.m.martins@...cle.com, boris.ostrovsky@...cle.com,
        linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote:
> 
> On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
> > On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
> > > On 2020/10/14 上午7:42, si-wei liu wrote:
> > > > > 
> > > > > So what I suggest is to fix the pinning leakage first and do the
> > > > > possible optimization on top (which is still questionable to me).
> > > > OK. Unfortunately, this was picked and got merged in upstream. So I will
> > > > post a follow up patch set to 1) revert the commit to the original
> > > > __get_free_page() implementation, and 2) fix the accounting and leakage
> > > > on top. Will it be fine?
> > > 
> > > Fine.
> > > 
> > > Thanks
> > Fine by me too.
> > 
> Thanks, Michael & Jason. I will post the fix shortly. Stay tuned.
> 
> -Siwei

did I miss the patch?