netdev - Re: [PATCH bpf v2] bpf: zero-fill re-used per-cpu map element

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZBn9HWhTeyaOLXYwJtdandx44a8oJLjBunFUgjoN5Udw@mail.gmail.com>
Date:   Thu, 29 Oct 2020 15:40:20 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     David Verbeiren <david.verbeiren@...sares.net>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Matthieu Baerts <matthieu.baerts@...sares.net>
Subject: Re: [PATCH bpf v2] bpf: zero-fill re-used per-cpu map element

On Thu, Oct 29, 2020 at 7:44 AM David Verbeiren
<david.verbeiren@...sares.net> wrote:
>
> On Tue, Oct 27, 2020 at 11:55 PM Andrii Nakryiko
> <andrii.nakryiko@...il.com> wrote:
> > Looks good, but would be good to have a unit test (see below). Maybe
> > in a follow up.
>
> Here is the associated new selftest, implementing the sequence you
> proposed (thanks for that!), and also one for LRU case:
> https://lore.kernel.org/bpf/20201029111730.6881-1-david.verbeiren@tessares.net/
>
> I hope I did it in the "right" framework of the day.

You did it in a very laborious and hard way, which will be harder to
maintain, unfortunately. But it should be trivial to simplify it with
skeleton. It's probably better to combine the selftest patch with the
kernel fix in this patch and send it as v2?