netdev - Re: [PATCH net v1] net: protect tcf_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201027180331.42ece60f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 27 Oct 2020 18:03:31 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Leon Romanovsky <leonro@...dia.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Vlad Buslov <vladbu@...dia.com>
Subject: Re: [PATCH net v1] net: protect tcf_block_unbind with block lock

On Mon, 26 Oct 2020 14:33:27 +0200 Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
> 
> The tcf_block_unbind() expects that the caller will take block->cb_lock
> before calling it, however the code took RTNL lock and dropped cb_lock
> instead. This causes to the following kernel panic.
 
> Fixes: 0fdcf78d5973 ("net: use flow_indr_dev_setup_offload()")
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> ---
> v1:
>  * Returned rtnl_lock()
> v0:
> https://lore.kernel.org/netdev/20201026060407.583080-1-leon@kernel.org

Applied, thanks. 

I'm surprised you put the lore link in the notes. Maybe the usefulness
of the change log could be argued, but the number of times I tried to
find a specific revision and couldn't...