netdev - Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201027175430.1f6a74b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 27 Oct 2020 17:54:30 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Thomas Bogendoerfer <tbogendoerfer@...e.de>
Cc:     Michal Suchanek <msuchanek@...e.de>, netdev@...r.kernel.org,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Cristobal Forno <cforno12@...ux.ibm.com>,
        "David S. Miller" <davem@...emloft.net>,
        Cris Forno <cforno12@...ux.vnet.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge.

On Mon, 26 Oct 2020 20:04:07 +0100 Thomas Bogendoerfer wrote:
> > On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote:  
> > > From: Thomas Bogendoerfer <tbogendoerfer@...e.de>
> > > 
> > > The check for src mac address in ibmveth_is_packet_unsupported is wrong.
> > > Commit 6f2275433a2f wanted to shut down messages for loopback packets,
> > > but now suppresses bridged frames, which are accepted by the hypervisor
> > > otherwise bridging won't work at all.
> > > 
> > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor")
> > > Signed-off-by: Michal Suchanek <msuchanek@...e.de>  
> > 
> > Since the From: line says Thomas we need a signoff from him.  
> 
> you can add
> 
> Signed-off-by: tbogendoerfer@...e.de

Applied, thanks.