netdev - Re: [PATCH net-next v2 0/5] Support for RollBall 10G copper SFP modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Oct 2020 15:01:38 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next v2 0/5] Support for RollBall 10G copper SFP
 modules

A general point: please have me in the To: line rather than the Cc:
line so that I can find emails better; I've just spent quite a while
trying to find this series you posted last night amongst all the
other emails that I'm Cc'd on.

(The difference between To: and Cc: is that you expect those in the To:
header to be the primary recipients who you expect action from, and
those in the Cc: to be secondary recipients for information.)

https://blog.thedigitalgroup.com/to-vs-cc-vs-bcc-how-to-use-them-correctly
https://www.writebetteremails.com/to-cc.htm
https://thinkproductive.co.uk/email-using-cc-bcc-to/
... etc ...

Thanks.

On Thu, Oct 29, 2020 at 11:25:04PM +0100, Marek Behún wrote:
> Hello,
> 
> this is v2 of series adding support for RollBall/Hilink SFP modules.
> 
> Checked with:
>   checkpatch.pl --max-line-length=80
> 
> Changes from v1:
> - wrapped to 80 columns as per Russell's request
> - initialization of RollBall MDIO I2C protocol moved from sfp.c to
>   mdio-i2c.c as per Russell's request
> - second patch removes the 802.3z check also from phylink_sfp_config
>   as suggested by Russell
> - creation/destruction of mdiobus for SFP now occurs before probing
>   for PHY/after releasing PHY (as suggested by Russell)
> - the last patch became a little simpler after the above was done
> 
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Russell King <rmk+kernel@...linux.org.uk>
> 
> Marek Behún (5):
>   net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules
>   net: phylink: allow attaching phy for SFP modules on 802.3z mode
>   net: sfp: create/destroy I2C mdiobus before PHY probe/after PHY
>     release
>   net: phy: marvell10g: change MACTYPE if underlying MAC does not
>     support it
>   net: sfp: add support for multigig RollBall transceivers
> 
>  drivers/net/mdio/mdio-i2c.c   | 232 +++++++++++++++++++++++++++++++++-
>  drivers/net/phy/marvell10g.c  |  31 +++++
>  drivers/net/phy/phylink.c     |   5 +-
>  drivers/net/phy/sfp.c         |  67 ++++++++--
>  include/linux/mdio/mdio-i2c.h |   8 +-
>  5 files changed, 322 insertions(+), 21 deletions(-)
> 
> 
> base-commit: cd29296fdfca919590e4004a7e4905544f4c4a32
> -- 
> 2.26.2
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!