netdev - Re: [PATCH v2] net: fec: fix MDIO probing for some FEC hardware blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201030082620.0a71ea51@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Fri, 30 Oct 2020 08:26:25 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Greg Ungerer <gerg@...ux-m68k.org>, netdev@...r.kernel.org,
        fugang.duan@....com, cphealy@...il.com, dkarr@...x.com,
        clemens.gruber@...ruber.com
Subject: Re: [PATCH v2] net: fec: fix MDIO probing for some FEC hardware
 blocks

On Fri, 30 Oct 2020 01:02:47 +0100 Andrew Lunn wrote:
> On Wed, Oct 28, 2020 at 03:22:32PM +1000, Greg Ungerer wrote:
> > Some (apparently older) versions of the FEC hardware block do not like
> > the MMFR register being cleared to avoid generation of MII events at
> > initialization time. The action of clearing this register results in no
> > future MII events being generated at all on the problem block. This means
> > the probing of the MDIO bus will find no PHYs.
> > 
> > Create a quirk that can be checked at the FECs MII init time so that
> > the right thing is done. The quirk is set as appropriate for the FEC
> > hardware blocks that are known to need this.
> > 
> > Fixes: f166f890c8f0 ("net: ethernet: fec: Replace interrupt driven MDIO with polled IO")
> > Signed-off-by: Greg Ungerer <gerg@...ux-m68k.org>  
> 
> Tested-by: Andrew Lunn <andrew@...n.ch>
> 
> I tested this on Vybrid, which is not the best of platforms, since i
> never had any of these problems on this platform.
> 
> Jakub, this is for net.

Applied, thanks everyone!