netdev - Re: [PATCH net v2] cadence: force nonlinear buffers to be cloned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201030082905.78df525f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Fri, 30 Oct 2020 08:29:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Mark Deneen <mdeneen@...contech.com>
Cc:     netdev@...r.kernel.org, nicolas.ferre@...rochip.com,
        claudiu.beznea@...rochip.com, Klaus Doth <krnl@...h.eu>
Subject: Re: [PATCH net v2] cadence: force nonlinear buffers to be cloned

On Fri, 30 Oct 2020 12:51:39 +0000 Mark Deneen wrote:
> Suggested-by: Klaus Doth <krnl@...h.eu>
> Fixes: 653e92a91 ("macb: add support for padding and fcs computation")

Fixes tag: Fixes: 653e92a91 ("macb: add support for padding and fcs computation")
Has these problem(s):
	- SHA1 should be at least 12 digits long
	  Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
	  or later) just making sure it is not set (or set to "auto").
	- Subject does not match target commit subject
	  Just use
		git log -1 --format='Fixes: %h ("%s")'

>  static int macb_pad_and_fcs(struct sk_buff **skb, struct net_device *ndev)
>  {
> -	bool cloned = skb_cloned(*skb) || skb_header_cloned(*skb);
> +	bool cloned = skb_cloned(*skb) || skb_header_cloned(*skb) ||
> +	              skb_is_nonlinear(*skb);
>  	int padlen = ETH_ZLEN - (*skb)->len;
>  	int headroom = skb_headroom(*skb);
>  	int tailroom = skb_tailroom(*skb);

Checkpatch says:

ERROR: code indent should use tabs where possible
#89: FILE: drivers/net/ethernet/cadence/macb_main.c:1933:
+^I              skb_is_nonlinear(*skb);$