netdev - Re: [PATCH bpf-next 0/2] bpf: safeguard hashtab locking in NMI context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160408920507.23182.15914549359111070599.git-patchwork-notify@kernel.org>
Date:   Fri, 30 Oct 2020 20:20:05 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Song Liu <songliubraving@...com>
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org, kernel-team@...com,
        ast@...nel.org, daniel@...earbox.net, john.fastabend@...il.com,
        kpsingh@...omium.org
Subject: Re: [PATCH bpf-next 0/2] bpf: safeguard hashtab locking in NMI context

Hello:

This series was applied to bpf/bpf-next.git (refs/heads/master):

On Thu, 29 Oct 2020 00:19:23 -0700 you wrote:
> LOCKDEP NMI warning highlighted potential deadlock of hashtab in NMI
> context:
> 
> [   74.828971] ================================
> [   74.828972] WARNING: inconsistent lock state
> [   74.828973] 5.9.0-rc8+ #275 Not tainted
> [   74.828974] --------------------------------
> [   74.828975] inconsistent {INITIAL USE} -> {IN-NMI} usage.
> [   74.828976] taskset/1174 [HC2[2]:SC0[0]:HE0:SE1] takes:
> [...]
> [   74.828999]  Possible unsafe locking scenario:
> [   74.828999]
> [   74.829000]        CPU0
> [   74.829001]        ----
> [   74.829001]   lock(&htab->buckets[i].raw_lock);
> [   74.829003]   <Interrupt>
> [   74.829004]     lock(&htab->buckets[i].raw_lock);
> 
> [...]

Here is the summary with links:
  - [bpf-next,1/2] bpf: use separate lockdep class for each hashtab
    https://git.kernel.org/bpf/bpf-next/c/c50eb518e262
  - [bpf-next,2/2] bpf: Avoid hashtab deadlock with map_locked
    https://git.kernel.org/bpf/bpf-next/c/20b6cc34ea74

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html