netdev - Re: [PATCH net-next 0/4] sfc: EF100 TSO enhancements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201030174537.7fec9ae4@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Fri, 30 Oct 2020 17:45:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] sfc: EF100 TSO enhancements

On Wed, 28 Oct 2020 20:41:21 +0000 Edward Cree wrote:
> Support TSO over encapsulation (with GSO_PARTIAL), and over VLANs
>  (which the code already handled but we didn't advertise).  Also
>  correct our handling of IPID mangling.
> 
> I couldn't find documentation of exactly what shaped SKBs we can
>  get given, so patch #2 is slightly guesswork, but when I tested
>  TSO over both underlay and (VxLAN) overlay, the checksums came
>  out correctly, so at least in those cases the edits we're making
>  must be the right ones.
> Similarly, I'm not 100% sure I've correctly understood how FIXEDID
>  and MANGLEID are supposed to work in patch #3.

Applied, thanks everyone!