netdev - Re: [PATCHv6 net 0/2] IPv6: reply ICMP error if fragment doesn't contain all headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201031141252.25da81fd@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Sat, 31 Oct 2020 14:12:52 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Willem de Bruijn <willemb@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Georg Kohmann <geokohma@...co.com>
Subject: Re: [PATCHv6 net 0/2] IPv6: reply ICMP error if fragment doesn't
 contain all headers

On Tue, 27 Oct 2020 20:33:11 +0800 Hangbin Liu wrote:
> When our Engineer run latest IPv6 Core Conformance test, test v6LC.1.3.6:
> First Fragment Doesn’t Contain All Headers[1] failed. The test purpose is to
> verify that the node(Linux for example) should properly process IPv6 packets
> that don’t include all the headers through the Upper-Layer header.
> 
> Based on RFC 8200, Section 4.5 Fragment Header
> 
>   -  If the first fragment does not include all headers through an
>      Upper-Layer header, then that fragment should be discarded and
>      an ICMP Parameter Problem, Code 3, message should be sent to
>      the source of the fragment, with the Pointer field set to zero.
> 
> The first patch add a definition for ICMPv6 Parameter Problem, code 3.
> The second patch add a check for the 1st fragment packet to make sure
> Upper-Layer header exist.

Applied, thank you!