netdev - Re: [PATCH net v2 2/2] dpaa_eth: fix the RX headroom size alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201030184347.4a8ad004@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Fri, 30 Oct 2020 18:43:47 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Camelia Groza <camelia.groza@....com>
Cc:     willemdebruijn.kernel@...il.com, madalin.bucur@....nxp.com,
        davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net v2 2/2] dpaa_eth: fix the RX headroom size alignment

On Wed, 28 Oct 2020 18:41:00 +0200 Camelia Groza wrote:
> @@ -2842,7 +2842,8 @@ static int dpaa_ingress_cgr_init(struct dpaa_priv *priv)
>  	return err;
>  }
> 
> -static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl)
> +static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl,
> +				    enum port_type port)

Please drop the "inline" while you're touching this definition.

The compiler will make the right inlining decision here.