lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 31 Oct 2020 09:38:57 -0600 From: David Ahern <dsahern@...il.com> To: Petr Machata <me@...chata.org>, netdev@...r.kernel.org, stephen@...workplumber.org Cc: john.fastabend@...il.com, jiri@...dia.com, idosch@...dia.com, Jakub Kicinski <kuba@...nel.org>, Roman Mashak <mrv@...atatu.com> Subject: Re: [PATCH iproute2-next v2 03/11] lib: utils: Add print_on_off_bool() On 10/30/20 6:29 AM, Petr Machata wrote: > diff --git a/include/utils.h b/include/utils.h > index bd62cdcd7122..e3cdb098834a 100644 > --- a/include/utils.h > +++ b/include/utils.h > @@ -328,5 +328,6 @@ int do_batch(const char *name, bool force, > int parse_one_of(const char *msg, const char *realval, const char * const *list, > size_t len, int *p_err); > int parse_on_off(const char *msg, const char *realval, int *p_err); > +void print_on_off_bool(FILE *fp, const char *flag, bool val); > > #endif /* __UTILS_H__ */ > diff --git a/lib/utils.c b/lib/utils.c > index 930877ae0f0d..8deec86ecbcd 100644 > --- a/lib/utils.c > +++ b/lib/utils.c > @@ -1763,3 +1763,11 @@ int parse_on_off(const char *msg, const char *realval, int *p_err) > > return parse_one_of(msg, realval, values_on_off, ARRAY_SIZE(values_on_off), p_err); > } > + > +void print_on_off_bool(FILE *fp, const char *flag, bool val) > +{ > + if (is_json_context()) > + print_bool(PRINT_JSON, flag, NULL, val); > + else > + fprintf(fp, "%s %s ", flag, val ? "on" : "off"); > +} > I think print_on_off should be fine and aligns with parse_on_off once it returns a bool.
Powered by blists - more mailing lists