netdev - Re: [PATCH v2] lan743x: Fix for potential null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201101203820.GD1109407@lunn.ch>
Date:   Sun, 1 Nov 2020 21:38:20 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Sergej Bauer <sbauer@...ckbox.su>
Cc:     Markus Elfring <Markus.Elfring@....de>, netdev@...r.kernel.org,
        UNGLinuxDriver@...rochip.com, linux-kernel@...r.kernel.org,
        Bryan Whitehead <bryan.whitehead@...rochip.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2] lan743x: Fix for potential null pointer dereference

On Sun, Nov 01, 2020 at 10:54:38PM +0300, Sergej Bauer wrote:
> > > Signed-off-by: Sergej Bauer <sbauer@...ckbox.su>
> > 
> > * I miss a change description here.
> The reason for the fix is when the device is down netdev->phydev will be NULL 
> and there is no checking for this situation. So 'ethtool ethN' leads to kernel 
> panic.

> > > @@ -809,9 +812,12 @@ static int lan743x_ethtool_set_wol(struct net_device
> > > *netdev,> 
> > >  	device_set_wakeup_enable(&adapter->pdev->dev, (bool)wol->wolopts);
> > > 
> > > -	phy_ethtool_set_wol(netdev->phydev, wol);
> > > +	if (netdev->phydev)
> > > +		ret = phy_ethtool_set_wol(netdev->phydev, wol);
> > > +	else
> > > +		ret = -EIO;

-ENETDOWN would be better, it gives a hit that WoL can be configured
when the interface is configured up.

 Andrew