netdev - Re: [PATCH] xfrm/compat: Remove use of kmalloc_track

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a85a545-a663-828a-387e-fd4a0e2ae747@gmail.com>
Date:   Sun, 1 Nov 2020 23:34:11 +0000
From:   Dmitry Safonov <0x7f454c46@...il.com>
To:     Alistair Delva <adelva@...gle.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        kernel-team@...roid.com,
        Maciej Żenczykowski <maze@...gle.com>,
        Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [PATCH] xfrm/compat: Remove use of kmalloc_track_caller

On 11/1/20 10:08 PM, Alistair Delva wrote:
> The __kmalloc_track_caller symbol is not exported if SLUB/SLOB are
> enabled instead of SLAB, which breaks the build on such configs when
> CONFIG_XFRM_USER_COMPAT=m.
> 
> ERROR: "__kmalloc_track_caller" [net/xfrm/xfrm_compat.ko] undefined!
> 
> Other users of this symbol are 'bool' options, but changing this to
> bool would require XFRM_USER to be built in as well, which doesn't
> seem worth it. Go back to kmalloc().
> 
> Fixes: 96392ee5a13b9 ("xfrm/compat: Translate 32-bit user_policy from sockptr")
> Cc: Dmitry Safonov <0x7f454c46@...il.com>
> Cc: Maciej Żenczykowski <maze@...gle.com>
> Cc: Steffen Klassert <steffen.klassert@...unet.com>
> Signed-off-by: Alistair Delva <adelva@...gle.com>

Reviewed-by: Dmitry Safonov <0x7f454c46@...il.com>

Thank you!

--
          Dmitry