netdev - Re: EXPORT_SYMBOL or EXPORT_SYMBOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201101162429.GB1109407@lunn.ch>
Date:   Sun, 1 Nov 2020 17:24:29 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: EXPORT_SYMBOL or EXPORT_SYMBOL_GPL?

On Sun, Nov 01, 2020 at 01:43:34PM +0100, Heiner Kallweit wrote:
> I was wondering whether we have any policy on using EXPORT_SYMBOL or
> EXPORT_SYMBOL_GPL for newly exported functions. I've seen both options
> being used.

Hi Heiner

In the case of dev_get_tstats64() it is a trivial function to open
code in a driver. It is not going to cause any hardship for a closed
source out of tree network driver. So it makes no difference.
The existing stats functions in net/core/dev.c:

EXPORT_SYMBOL(netdev_stats_to_stats64);
EXPORT_SYMBOL(dev_get_stats);
EXPORT_SYMBOL_GPL(dev_fetch_sw_netstats);

so there is no general patterns to follow, pick whatever your want.

	Andrew