| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20201102150651.GA4379@in.ibm.com>
Date: Mon, 2 Nov 2020 20:36:51 +0530
From: Gautham R Shenoy <ego@...ux.vnet.ibm.com>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Linux Doc Mailing List <linux-doc@...r.kernel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
"Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>,
"Jason A. Donenfeld" <Jason@...c4.com>,
Javier González <javier@...igon.com>,
Jonathan Corbet <corbet@....net>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Alexandre Torgue <alexandre.torgue@...com>,
Andrew Donnellan <ajd@...ux.ibm.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Baolin Wang <baolin.wang7@...il.com>,
Benson Leung <bleung@...omium.org>,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
Bruno Meneguele <bmeneg@...hat.com>,
Chunyan Zhang <zhang.lyra@...il.com>,
Dan Murphy <dmurphy@...com>,
Dan Williams <dan.j.williams@...el.com>,
Enric Balletbo i Serra <enric.balletbo@...labora.com>,
Fabrice Gasnier <fabrice.gasnier@...com>,
Felipe Balbi <balbi@...nel.org>,
Frederic Barrat <fbarrat@...ux.ibm.com>,
Guenter Roeck <groeck@...omium.org>,
Hanjun Guo <guohanjun@...wei.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Jens Axboe <axboe@...nel.dk>,
Johannes Thumshirn <johannes.thumshirn@....com>,
Jonathan Cameron <jic23@...nel.org>,
Juergen Gross <jgross@...e.com>,
Konstantin Khlebnikov <koct9i@...il.com>,
Kranthi Kuntala <kranthi.kuntala@...el.com>,
Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>,
Lars-Peter Clausen <lars@...afoo.de>,
Len Brown <lenb@...nel.org>,
Leonid Maksymchuk <leonmaxx@...il.com>,
Ludovic Desroches <ludovic.desroches@...rochip.com>,
Mario Limonciello <mario.limonciello@...l.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Michael Ellerman <mpe@...erman.id.au>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Mike Kravetz <mike.kravetz@...cle.com>,
Mimi Zohar <zohar@...ux.ibm.com>,
Nayna Jain <nayna@...ux.ibm.com>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Niklas Cassel <niklas.cassel@....com>,
Oleh Kravchenko <oleg@....org.ua>,
Orson Zhai <orsonzhai@...il.com>, Pavel Machek <pavel@....cz>,
Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
Peter Meerwald-Stadler <pmeerw@...erw.net>,
Peter Rosin <peda@...ntia.se>, Petr Mladek <pmladek@...e.com>,
Philippe Bergheaud <felix@...ux.ibm.com>,
Richard Cochran <richardcochran@...il.com>,
Sebastian Reichel <sre@...nel.org>,
Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
Stefano Stabellini <sstabellini@...nel.org>,
Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
Thomas Gleixner <tglx@...utronix.de>,
Vineela Tummalapalli <vineela.tummalapalli@...el.com>,
Vishal Verma <vishal.l.verma@...el.com>,
linux-acpi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, linux-pm@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-usb@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
netdev@...r.kernel.org, xen-devel@...ts.xenproject.org
Subject: Re: [PATCH 20/33] docs: ABI: testing: make the files compatible with
ReST output
On Wed, Oct 28, 2020 at 03:23:18PM +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
>
> Some files over there won't parse well by Sphinx.
>
[..snip..]
> diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
> index b555df825447..274c337ec6a9 100644
> --- a/Documentation/ABI/testing/sysfs-devices-system-cpu
> +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
> @@ -151,23 +151,28 @@ Description:
> The processor idle states which are available for use have the
> following attributes:
>
> - name: (RO) Name of the idle state (string).
> + ======== ==== =================================================
> + name: (RO) Name of the idle state (string).
>
> latency: (RO) The latency to exit out of this idle state (in
> - microseconds).
> + microseconds).
>
> - power: (RO) The power consumed while in this idle state (in
> - milliwatts).
> + power: (RO) The power consumed while in this idle state (in
> + milliwatts).
>
> - time: (RO) The total time spent in this idle state (in microseconds).
> + time: (RO) The total time spent in this idle state
> + (in microseconds).
>
> - usage: (RO) Number of times this state was entered (a count).
> + usage: (RO) Number of times this state was entered (a count).
>
> - above: (RO) Number of times this state was entered, but the
> - observed CPU idle duration was too short for it (a count).
> + above: (RO) Number of times this state was entered, but the
> + observed CPU idle duration was too short for it
> + (a count).
>
> - below: (RO) Number of times this state was entered, but the
> - observed CPU idle duration was too long for it (a count).
> + below: (RO) Number of times this state was entered, but the
> + observed CPU idle duration was too long for it
> + (a count).
> + ======== ==== =================================================
>
> What: /sys/devices/system/cpu/cpuX/cpuidle/stateN/desc
> Date: February 2008
> @@ -290,6 +295,7 @@ Description: Processor frequency boosting control
> This switch controls the boost setting for the whole system.
> Boosting allows the CPU and the firmware to run at a frequency
> beyound it's nominal limit.
> +
> More details can be found in
> Documentation/admin-guide/pm/cpufreq.rst
>
The changes to cpuidle states look good to me.
[..snip..]
> @@ -414,30 +434,30 @@ Description: POWERNV CPUFreq driver's frequency throttle stats directory and
> throttle attributes exported in the 'throttle_stats' directory:
>
> - turbo_stat : This file gives the total number of times the max
> - frequency is throttled to lower frequency in turbo (at and above
> - nominal frequency) range of frequencies.
> + frequency is throttled to lower frequency in turbo (at and above
> + nominal frequency) range of frequencies.
>
> - sub_turbo_stat : This file gives the total number of times the
> - max frequency is throttled to lower frequency in sub-turbo(below
> - nominal frequency) range of frequencies.
> + max frequency is throttled to lower frequency in sub-turbo(below
> + nominal frequency) range of frequencies.
>
> - unthrottle : This file gives the total number of times the max
> - frequency is unthrottled after being throttled.
> + frequency is unthrottled after being throttled.
>
> - powercap : This file gives the total number of times the max
> - frequency is throttled due to 'Power Capping'.
> + frequency is throttled due to 'Power Capping'.
>
> - overtemp : This file gives the total number of times the max
> - frequency is throttled due to 'CPU Over Temperature'.
> + frequency is throttled due to 'CPU Over Temperature'.
>
> - supply_fault : This file gives the total number of times the
> - max frequency is throttled due to 'Power Supply Failure'.
> + max frequency is throttled due to 'Power Supply Failure'.
>
> - overcurrent : This file gives the total number of times the
> - max frequency is throttled due to 'Overcurrent'.
> + max frequency is throttled due to 'Overcurrent'.
>
> - occ_reset : This file gives the total number of times the max
> - frequency is throttled due to 'OCC Reset'.
> + frequency is throttled due to 'OCC Reset'.
>
> The sysfs attributes representing different throttle reasons like
> powercap, overtemp, supply_fault, overcurrent and occ_reset map to
This hunk for the powernv cpufreq driver looks good to me.
For these two hunks,
Reviewed-by: Gautham R. Shenoy <ego@...ux.vnet.ibm.com>
Powered by blists - more mailing lists