netdev - RE: [PATCH net v2 2/2] dpaa_eth: fix the RX headroom size alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR04MB580769648827F02236580080F2100@VI1PR04MB5807.eurprd04.prod.outlook.com>
Date:   Mon, 2 Nov 2020 17:09:09 +0000
From:   Camelia Alexandra Groza <camelia.groza@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
        "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net v2 2/2] dpaa_eth: fix the RX headroom size alignment

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Saturday, October 31, 2020 03:44
> To: Camelia Alexandra Groza <camelia.groza@....com>
> Cc: willemdebruijn.kernel@...il.com; Madalin Bucur (OSS)
> <madalin.bucur@....nxp.com>; davem@...emloft.net;
> netdev@...r.kernel.org
> Subject: Re: [PATCH net v2 2/2] dpaa_eth: fix the RX headroom size
> alignment
> 
> On Wed, 28 Oct 2020 18:41:00 +0200 Camelia Groza wrote:
> > @@ -2842,7 +2842,8 @@ static int dpaa_ingress_cgr_init(struct dpaa_priv
> *priv)
> >  	return err;
> >  }
> >
> > -static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl)
> > +static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl,
> > +				    enum port_type port)
> 
> Please drop the "inline" while you're touching this definition.
> 
> The compiler will make the right inlining decision here.

Sure, I'll drop it.