netdev - Re: [PATCH v2] brcmfmac: Fix memory leak for unpaired brcmf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h7q7odnr.fsf@codeaurora.org>
Date:   Mon, 02 Nov 2020 19:46:00 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Arend Van Spriel <arend.vanspriel@...adcom.com>
Cc:     "Seung-Woo Kim" <sw0312.kim@...sung.com>,
        <franky.lin@...adcom.com>, <hante.meuleman@...adcom.com>,
        <chi-hsien.lin@...ress.com>, <wright.feng@...ress.com>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-wireless@...r.kernel.org>,
        <brcm80211-dev-list.pdl@...adcom.com>,
        <brcm80211-dev-list@...ress.com>, <smoch@....de>,
        <sandals@...stytoothpaste.net>, <rafal@...ecki.pl>,
        <digetx@...il.com>, <double.lo@...ress.com>, <amsr@...ress.com>,
        <stanley.hsu@...ress.com>, <saravanan.shanmugham@...ress.com>,
        <jean-philippe@...aro.org>, <frank.kao@...ress.com>,
        <netdev@...r.kernel.org>, <jh80.chung@...sung.com>
Subject: Re: [PATCH v2] brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free}

Arend Van Spriel <arend.vanspriel@...adcom.com> writes:

> On November 2, 2020 6:15:32 PM Kalle Valo <kvalo@...eaurora.org> wrote:
>
>> Seung-Woo Kim <sw0312.kim@...sung.com> writes:
>>
>>> There are missig brcmf_free() for brcmf_alloc(). Fix memory leak
>>> by adding missed brcmf_free().
>>>
>>> Reported-by: Jaehoon Chung <jh80.chung@...sung.com>
>>> Fixes: commit 450914c39f88 ("brcmfmac: split brcmf_attach() and
>>> brcmf_detach() functions")
>>
>> This should be:
>>
>> Fixes: 450914c39f88 ("brcmfmac: split brcmf_attach() and
>> brcmf_detach() functions")
>>
>> But I can fix that, no need to resend because of this.
>
> Hi Kalle,
>
> But this is not the commit that needs fixing as I mentioned before.
> Instead it should be a1f5aac1765af ("brcmfmac: don't realloc wiphy
> during PCIe reset") which introduced the actual memory leak.

I'll then change it to:

Fixes: a1f5aac1765a ("brcmfmac: don't realloc wiphy during PCIe reset")

Is that ok?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches