netdev - Re: [PATCH net-next 10/13] octeontx2-pf: Add support for SR-IOV management functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201102095458.024ab1e9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 2 Nov 2020 09:54:58 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Naveen Mamindlapalli <naveenm@...vell.com>
Cc:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <davem@...emloft.net>, <sgoutham@...vell.com>,
        <lcherian@...vell.com>, <gakula@...vell.com>, <jerinj@...vell.com>,
        <sbhatta@...vell.com>, <hkelam@...vell.com>,
        Tomasz Duszynski <tduszynski@...vell.com>
Subject: Re: [PATCH net-next 10/13] octeontx2-pf: Add support for SR-IOV
 management functions

On Mon, 2 Nov 2020 11:41:19 +0530 Naveen Mamindlapalli wrote:
> This patch adds support for ndo_set_vf_mac, ndo_set_vf_vlan
> and ndo_get_vf_config handlers. The traffic redirection
> based on the VF mac address or vlan id is done by installing
> MCAM rules. Reserved RX_VTAG_TYPE7 in each NIXLF for VF VLAN
> which strips the VLAN tag from ingress VLAN traffic. The NIX PF
> allocates two MCAM entries for VF VLAN feature, one used for
> ingress VTAG strip and another entry for egress VTAG insertion.
> 
> This patch also updates the MAC address in PF installed VF VLAN
> rule upon receiving nix_lf_start_rx mbox request for VF since
> Administrative Function driver will assign a valid MAC addr
> in nix_lf_start_rx function.
> 
> Signed-off-by: Naveen Mamindlapalli <naveenm@...vell.com>
> Co-developed-by: Tomasz Duszynski <tduszynski@...vell.com>
> Signed-off-by: Tomasz Duszynski <tduszynski@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> Signed-off-by: Hariprasad Kelam <hkelam@...vell.com>

drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast to restricted __be16
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast to restricted __be16
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast to restricted __be16
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast to restricted __be16
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2158:55: warning: incorrect type in argument 5 (different base types)
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2158:55:    expected unsigned short [usertype] proto
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2158:55:    got restricted __be16 [usertype] proto
203a211,214
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c: In function ‘npc_update_dmac_value’:
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:1236:24: warning: implicit conversion from ‘enum header_fields’ to ‘enum key_fields’ [-Wenum-conversion]
 1236 |  npc_update_entry(rvu, NPC_DMAC, entry,
      |                        ^~~~~~~~