netdev - Re: [PATCH bpf-next 05/11] selftests/bpf: add split BTF basic test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62331693-EDCE-4173-86C0-D9E771DA5C22@fb.com>
Date:   Mon, 2 Nov 2020 23:36:42 +0000
From:   Song Liu <songliubraving@...com>
To:     Andrii Nakryiko <andrii@...nel.org>
CC:     "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next 05/11] selftests/bpf: add split BTF basic test



> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko <andrii@...nel.org> wrote:
> 
> Add selftest validating ability to programmatically generate and then dump
> split BTF.
> 
> Signed-off-by: Andrii Nakryiko <andrii@...nel.org>

Acked-by: Song Liu <songliubraving@...com>

With a nit:

[...]
> 
> +
> +static void btf_dump_printf(void *ctx, const char *fmt, va_list args)
> +{
> +	vfprintf(ctx, fmt, args);
> +}
> +
> +void test_btf_split() {
> +	struct btf_dump_opts opts;
> +	struct btf_dump *d = NULL;
> +	const struct btf_type *t;
> +	struct btf *btf1, *btf2 = NULL;

No need to initialize btf2 to NULL. 

> +	int str_off, i, err;
> +
> +	btf1 = btf__new_empty();
> +	if (!ASSERT_OK_PTR(btf1, "empty_main_btf"))
> +		return;
> +
> 

[...]