netdev - Re: [PATCH net-next] drivers: net: tulip: Fix set but not used with W=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201102155128.5c80974e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 2 Nov 2020 15:51:28 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] drivers: net: tulip: Fix set but not used with
 W=1

On Sat, 31 Oct 2020 01:54:45 +0100 Andrew Lunn wrote:
> When compiled for platforms other than __i386__ or __x86_64__:
> 
> drivers/net/ethernet/dec/tulip/tulip_core.c: In function ‘tulip_init_one’:
> drivers/net/ethernet/dec/tulip/tulip_core.c:1296:13: warning: variable ‘last_irq’ set but not used [-Wunused-but-set-variable]
>  1296 |  static int last_irq;
> 
> Add more #if defined() to totally remove the code when not needed.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks!