netdev - Re: [PATCH ipsec] xfrm: Pass template address family to xfrm_state_look

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201103120839.GA10834@gondor.apana.org.au>
Date:   Tue, 3 Nov 2020 23:08:39 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Anthony DeRossi <ajderossi@...il.com>
Cc:     netdev@...r.kernel.org, steffen.klassert@...unet.com,
        davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH ipsec] xfrm: Pass template address family to
 xfrm_state_look_at

On Mon, Nov 02, 2020 at 06:32:19PM -0800, Anthony DeRossi wrote:
> This fixes a regression where valid selectors are incorrectly skipped
> when xfrm_state_find is called with a non-matching address family (e.g.
> when using IPv6-in-IPv4 ESP in transport mode).

Why are we even allowing v6-over-v4 in transport mode? Isn't that
the whole point of BEET mode?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt