netdev - Re: [next-next v3 05/10] net: cdc_ncm: convert tasklets to use new tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201103075515.7856d175@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 3 Nov 2020 07:55:15 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Allen Pais <apais@...ux.microsoft.com>
Cc:     Allen Pais <allen.lkml@...il.com>, davem@...emloft.net,
        m.grzeschik@...gutronix.de, paulus@...ba.org, oliver@...kum.org,
        woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        petkan@...leusys.com, netdev@...r.kernel.org,
        Romain Perier <romain.perier@...il.com>
Subject: Re: [next-next v3 05/10] net: cdc_ncm: convert tasklets to use new
 tasklet_setup() API

On Tue, 3 Nov 2020 13:02:26 +0530 Allen Pais wrote:
> >   
> >> @@ -815,7 +815,7 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct usb_interface *intf, u8 data_
> >>   
> >>   	hrtimer_init(&ctx->tx_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> >>   	ctx->tx_timer.function = &cdc_ncm_tx_timer_cb;
> >> -	tasklet_init(&ctx->bh, cdc_ncm_txpath_bh, (unsigned long)dev);
> >> +	tasklet_setup(&ctx->bh, cdc_ncm_txpath_bh);
> >>   	atomic_set(&ctx->stop, 0);
> >>   	spin_lock_init(&ctx->mtx);
> >>   
> >> @@ -1468,9 +1468,9 @@ static enum hrtimer_restart cdc_ncm_tx_timer_cb(struct hrtimer *timer)
> >>   	return HRTIMER_NORESTART;
> >>   }
> >>   
> >> -static void cdc_ncm_txpath_bh(unsigned long param)
> >> +static void cdc_ncm_txpath_bh(struct tasklet_struct *t)
> >>   {
> >> -	struct usbnet *dev = (struct usbnet *)param;
> >> +	struct usbnet *dev = from_tasklet(dev, t, bh);
> >>   	struct cdc_ncm_ctx *ctx = (struct cdc_ncm_ctx *)dev->data[0];
> >>   
> >>   	spin_lock_bh(&ctx->mtx);  
> > 
> > This one is wrong.
> > 
> > ctx is struct cdc_ncm_ctx, but you from_tasklet() struct usbdev.
> > They both happen to have a tasklet called bh in 'em.  
> 
>   from_tasklet() is struct usbnet. So it should pick the right bh isn't it?

Look at the tasklet_init / tasklet_setup line.

It used to pass dev as an argument. But the tasklet is in ctx.

Now there is no explicit param, do you gotta pick out of ctx.