netdev - RE: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with skb_cow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Nov 2020 17:08:43 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Julian Wiedmann <jwi@...ux.ibm.com>,
        Vladimir Oltean <olteanv@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "james.jurack@...tek.com" <james.jurack@...tek.com>
Subject: RE: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with
 skb_cow_head for PTP

>-----Original Message-----
>From: Julian Wiedmann <jwi@...ux.ibm.com>
>Sent: Tuesday, November 3, 2020 6:37 PM
>To: Vladimir Oltean <olteanv@...il.com>; Claudiu Manoil
><claudiu.manoil@....com>
>Cc: netdev@...r.kernel.org; David S . Miller <davem@...emloft.net>; Jakub
>Kicinski <kuba@...nel.org>; james.jurack@...tek.com
>Subject: Re: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with
>skb_cow_head for PTP
>
>On 03.11.20 18:13, Vladimir Oltean wrote:
[...]
>>
>> Still crashes for me:
>>
>
>Given the various skb modifications in its xmit path, I wonder why
>gianfar doesn't clear IFF_TX_SKB_SHARING.

Hi Vladimir,
Can you try the above suggestion on your setup?
Thanks.