netdev - Re: [PATCHv3 iproute2-next 1/5] configure: add check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3368c04-2887-3daf-8be8-8717960e9a18@gmail.com>
Date:   Tue, 3 Nov 2020 10:32:37 -0700
From:   David Ahern <dsahern@...il.com>
To:     Hangbin Liu <haliu@...hat.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        David Miller <davem@...emloft.net>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        Jiri Benc <jbenc@...hat.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Toke Høiland-Jørgensen 
        <toke@...hat.com>
Subject: Re: [PATCHv3 iproute2-next 1/5] configure: add check_libbpf() for
 later libbpf support

On 11/2/20 10:54 PM, Hangbin Liu wrote:
> On Mon, Nov 02, 2020 at 08:37:37AM -0700, David Ahern wrote:
>> On 10/29/20 9:11 AM, Hangbin Liu wrote:
>>> This patch adds a check to see if we support libbpf. By default the
>>> system libbpf will be used, but static linking against a custom libbpf
>>> version can be achieved by passing LIBBPF_DIR to configure. FORCE_LIBBPF
>>> can be set to force configure to abort if no suitable libbpf is found,
>>> which is useful for automatic packaging that wants to enforce the
>>> dependency.
>>>
>>
>> Add an option to force libbpf off and use of the legacy code. i.e, yes
>> it is installed, but don't use it.
>>
>> configure script really needs a usage to dump options like disabling libbpf.
>>
> 
> Shouldn't we use libbpf by default if system support? The same like libmnl.
> There is no options to force libnml off.
> 

configure scripts usually allow you to control options directly,
overriding the autoprobe.