netdev - Re: [PATCH net-next] drivers: net: wan: lmc: Fix W=1 set but used variable warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201102160454.13b6a61a@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 2 Nov 2020 16:04:54 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] drivers: net: wan: lmc: Fix W=1 set but used
 variable warnings

On Sat, 31 Oct 2020 19:14:17 +0100 Andrew Lunn wrote:
> drivers/net/wan/lmc/lmc_main.c: In function ‘lmc_ioctl’:
> drivers/net/wan/lmc/lmc_main.c:356:25: warning: variable ‘mii’ set but not used [-Wunused-but-set-variable]
>   356 |                     u16 mii;
>       |                         ^~~
> drivers/net/wan/lmc/lmc_main.c:427:25: warning: variable ‘mii’ set but not used [-Wunused-but-set-variable]
>   427 |                     u16 mii;
>       |                         ^~~
> drivers/net/wan/lmc/lmc_main.c: In function ‘lmc_interrupt’:
> drivers/net/wan/lmc/lmc_main.c:1188:9: warning: variable ‘firstcsr’ set but not used [-Wunused-but-set-variable]
>  1188 |     u32 firstcsr;
> 
> This file has funky indentation, and makes little use of tabs. Keep
> with this style in the patch, but that makes checkpatch unhappy.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks!