netdev - [PATCH 0/2] prevent potential access of uninitialized members in can_rcv() and canfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201103213906.24219-1-anant.thazhemadam@gmail.com>
Date:   Wed,  4 Nov 2020 03:09:04 +0530
From:   Anant Thazhemadam <anant.thazhemadam@...il.com>
To:     socketcan@...tkopp.net, mkl@...gutronix.de, davem@...emloft.net,
        kuba@...nel.org
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Anant Thazhemadam <anant.thazhemadam@...il.com>
Subject: [PATCH 0/2] prevent potential access of uninitialized members in can_rcv() and canfd_rcv()

In both can_rcv(), and canfd_rcv(), when skb->len = 0, cfd->len 
(which is uninitialized) is accessed by pr_warn_once().

Performing the validation check for cfd->len separately, after the 
validation check for skb->len is done, resolves this issue in both 
instances, without compromising the degree of detail provided in the
log messages.

Anant Thazhemadam (2):
  can: af_can: prevent potential access of uninitialized member in
    can_rcv()
  can: af_can: prevent potential access of uninitialized member in
    canfd_rcv()

 net/can/af_can.c | 38 ++++++++++++++++++++++++++++----------
 1 file changed, 28 insertions(+), 10 deletions(-)

-- 
2.25.1