netdev - Re: [net v4 07/10] ch_ktls: packet handling prior to start marker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201103125147.565dbf0c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 3 Nov 2020 12:51:47 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Rohit Maheshwari <rohitm@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, secdev@...lsio.com
Subject: Re: [net v4 07/10] ch_ktls: packet handling prior to start marker

On Fri, 30 Oct 2020 23:32:22 +0530 Rohit Maheshwari wrote:
> There could be a case where ACK for tls exchanges prior to start
> marker is missed out, and by the time tls is offloaded. This pkt
> should not be discarded and handled carefully. It could be
> plaintext alone or plaintext + finish as well.

By plaintext + finish you mean the start of offload falls in the middle
of a TCP skb? That should never happen. We force EOR when we turn on
TLS, so you should never see a TCP skb that needs to be half-encrypted.