netdev - Re: [PATCH v7 2/4] net: phy: Add 5GBASER interface mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201103031643.GJ1109407@lunn.ch>
Date:   Tue, 3 Nov 2020 04:16:43 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Pavana Sharma <pavana.sharma@...i.com>, ashkan.boldaji@...i.com,
        davem@...emloft.net, gregkh@...uxfoundation.org, kuba@...nel.org,
        linux-kernel@...r.kernel.org, marek.behun@....cz,
        netdev@...r.kernel.org, vivien.didelot@...il.com
Subject: Re: [PATCH v7 2/4] net: phy: Add 5GBASER interface mode

On Mon, Nov 02, 2020 at 06:12:32PM -0800, Florian Fainelli wrote:
> 
> 
> On 11/2/2020 5:34 PM, Pavana Sharma wrote:
> >> How many times have i asked for you to add kerneldoc for this new
> >> value? How many times have you not done so?
> > 
> > I have added kerneldoc comment for the new value added.
> > 
> >> NACK.
> > 
> >> If you don't understand a comment, please ask.
> > 
> > Ok, explain what do you expect by that comment.
> 
> What Andrew wants you to do is add a comment like this:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/include/linux/phy.h#n88

Hi Pavana

This should also help:

https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html

And please compile the kernel with the W=1 flag. Make sure changes you
make don't add new warnings. You will see a warning from this new enum
valu you are adding because it is not correctly documented.

       Andrew