netdev - Re: [PATCH net-next 02/13] octeontx2-af: Verify MCAM entry channel and PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <DM6PR18MB3212BE3C13B421D8865371F6A2110@DM6PR18MB3212.namprd18.prod.outlook.com>
Date:   Tue, 3 Nov 2020 05:06:19 +0000
From:   Naveen Mamindlapalli <naveenm@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        "Geethasowjanya Akula" <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Kiran Kumar Kokkilagadda <kirankumark@...vell.com>
Subject: Re: [PATCH net-next 02/13] octeontx2-af: Verify MCAM entry channel
 and PF_FUNC

Hi Jakub,

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Monday, November 2, 2020 11:23 PM
> To: Naveen Mamindlapalli <naveenm@...vell.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org;
> davem@...emloft.net; Sunil Kovvuri Goutham <sgoutham@...vell.com>; Linu
> Cherian <lcherian@...vell.com>; Geethasowjanya Akula
> <gakula@...vell.com>; Jerin Jacob Kollanukkaran <jerinj@...vell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@...vell.com>; Hariprasad Kelam
> <hkelam@...vell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@...vell.com>
> Subject: Re: [PATCH net-next 02/13] octeontx2-af: Verify MCAM entry
> channel and PF_FUNC
> 
> On Mon, 2 Nov 2020 11:41:11 +0530 Naveen Mamindlapalli wrote:
> > From: Subbaraya Sundeep <sbhatta@...vell.com>
> >
> > This patch adds support to verify the channel number sent by mailbox
> > requester before writing MCAM entry for Ingress packets.
> > Similarly for Egress packets, verifying the PF_FUNC sent by the
> > mailbox user.
> >
> > Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> > Signed-off-by: Kiran Kumar K <kirankumark@...vell.com>
> > Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> > Signed-off-by: Naveen Mamindlapalli <naveenm@...vell.com>
> 
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:81:17: warning: incorrect
> type in assignment (different base types)
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:81:17:    expected
> unsigned short [assigned] [usertype] pf_func
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:81:17:    got restricted
> __be16 [usertype]

I will fix these warnings in v2

Thanks,
Naveen